summaryrefslogtreecommitdiff
path: root/fml/lib/FML/Process
diff options
context:
space:
mode:
authorfukachan <fukachan>2005-05-27 03:03:31 +0000
committerfukachan <fukachan>2005-05-27 03:03:31 +0000
commite6fc837dba963f236db29e3e38d62f215980d428 (patch)
tree33f8f9ab40c5862ddaa9e3711edaa8218026ce8b /fml/lib/FML/Process
parent1059e0cd170476595b06d3522d3a7915ae86e3be (diff)
downloadfml8-e6fc837dba963f236db29e3e38d62f215980d428.tar.gz
fml8-e6fc837dba963f236db29e3e38d62f215980d428.tar.bz2
fml8-e6fc837dba963f236db29e3e38d62f215980d428.zip
fix comments (FNF)
Diffstat (limited to 'fml/lib/FML/Process')
-rw-r--r--fml/lib/FML/Process/Addr.pm8
-rw-r--r--fml/lib/FML/Process/CGI/Param.pm7
-rw-r--r--fml/lib/FML/Process/Calendar.pm18
-rw-r--r--fml/lib/FML/Process/ConfViewer.pm12
-rw-r--r--fml/lib/FML/Process/Emulate.pm11
-rw-r--r--fml/lib/FML/Process/Error.pm6
-rw-r--r--fml/lib/FML/Process/QueueManager.pm6
7 files changed, 37 insertions, 31 deletions
diff --git a/fml/lib/FML/Process/Addr.pm b/fml/lib/FML/Process/Addr.pm
index a10d9890..2858ba1d 100644
--- a/fml/lib/FML/Process/Addr.pm
+++ b/fml/lib/FML/Process/Addr.pm
@@ -1,9 +1,9 @@
#-*- perl -*-
#
-# Copyright (C) 2001,2002,2003,2004 Ken'ichi Fukamachi
+# Copyright (C) 2001,2002,2003,2004,2005 Ken'ichi Fukamachi
# All rights reserved.
#
-# $FML: Addr.pm,v 1.18 2004/04/23 04:10:35 fukachan Exp $
+# $FML: Addr.pm,v 1.19 2004/07/11 15:43:38 fukachan Exp $
#
package FML::Process::Addr;
@@ -236,7 +236,7 @@ sub _fmladdr
my $list = $sys->get_user_list();
for my $user (keys %$list) {
- # hmm, user is important than alias ? or not ?
+ # XXX MTA looks prefer alias then user, ok ?
unless (defined $aliases->{ $user }) {
$aliases->{ $user } = "$user (LOCAL USER)";
}
@@ -261,7 +261,7 @@ Ken'ichi Fukamachi
=head1 COPYRIGHT
-Copyright (C) 2001,2002,2003,2004 Ken'ichi Fukamachi
+Copyright (C) 2001,2002,2003,2004,2005 Ken'ichi Fukamachi
All rights reserved. This program is free software; you can
redistribute it and/or modify it under the same terms as Perl itself.
diff --git a/fml/lib/FML/Process/CGI/Param.pm b/fml/lib/FML/Process/CGI/Param.pm
index aa9cfcef..38a61bcf 100644
--- a/fml/lib/FML/Process/CGI/Param.pm
+++ b/fml/lib/FML/Process/CGI/Param.pm
@@ -1,10 +1,10 @@
#-*- perl -*-
#
-# Copyright (C) 2001,2002,2003,2004 Ken'ichi Fukamachi
+# Copyright (C) 2001,2002,2003,2004,2005 Ken'ichi Fukamachi
# All rights reserved. This program is free software; you can
# redistribute it and/or modify it under the same terms as Perl itself.
#
-# $FML: Param.pm,v 1.22 2004/01/21 03:40:43 fukachan Exp $
+# $FML: Param.pm,v 1.23 2004/07/23 13:08:56 fukachan Exp $
#
package FML::Process::CGI::Param;
@@ -109,6 +109,7 @@ sub safe_paramlist
$key = $safe_method_regexp->{ $key };
for my $x (param()) {
if ($x =~ /^$key$/) {
+ # XXX-TODO: $value is checked ???
my $value = defined param($x) ? param($x) : '';
if ($numregexp == 1) { push(@list, [ $1, $value ] );}
if ($numregexp == 2) { push(@list, [ $1, $2, $value ] );}
@@ -136,7 +137,7 @@ Ken'ichi Fukamachi
=head1 COPYRIGHT
-Copyright (C) 2001,2002,2003,2004 Ken'ichi Fukamachi
+Copyright (C) 2001,2002,2003,2004,2005 Ken'ichi Fukamachi
All rights reserved. This program is free software; you can
redistribute it and/or modify it under the same terms as Perl itself.
diff --git a/fml/lib/FML/Process/Calendar.pm b/fml/lib/FML/Process/Calendar.pm
index 081bf0c0..375340a4 100644
--- a/fml/lib/FML/Process/Calendar.pm
+++ b/fml/lib/FML/Process/Calendar.pm
@@ -1,9 +1,9 @@
#-*- perl -*-
#
-# Copyright (C) 2002,2003,2004 Ken'ichi Fukamachi
+# Copyright (C) 2002,2003,2004,2005 Ken'ichi Fukamachi
# All rights reserved.
#
-# $FML: Calendar.pm,v 1.14 2004/07/11 15:43:38 fukachan Exp $
+# $FML: Calendar.pm,v 1.15 2004/12/23 12:32:05 fukachan Exp $
#
package FML::Process::Calendar;
@@ -39,7 +39,7 @@ constructor.
=head2 prepare($args)
-load default configuration file to use path_* variables.
+load default configuration file to use $path_* variables.
=head2 verify_request($args)
@@ -51,7 +51,7 @@ main routine.
parse files under ~$user/.schedule/ directory and summarize it.
-Lastly, use w3m to show schedul as html table.
+Lastly, use w3m to show schedule as html table.
=head2 finish($args)
@@ -131,11 +131,13 @@ sub run
$mode = $option->{ m } if defined $option->{ m };
my $schedule_dir = $option->{ D } if defined $option->{ D };
my $schedule_file = $option->{ F } if defined $option->{ F };
- my $schargs = {
+ my $schargs = {
schedule_dir => $schedule_dir,
schedule_file => undef,
};
- my $schedule = new FML::Demo::Calendar $schargs;
+
+ # create a scheduler object.
+ my $schedule = new FML::Demo::Calendar $schargs;
# prepare output channel
my $tmpf = $schedule->tmpfilepath;
@@ -150,7 +152,7 @@ sub run
# set output mode
$schedule->set_mode( $mode );
- # -a option: show three calendars for this, next and last month.
+ # -a option: show three monthly calendars for this, next and last month.
if (defined($option->{ a })) {
for my $month ('this', 'next', 'last') {
$schedule->print_specific_month($wh, $month);
@@ -229,7 +231,7 @@ Ken'ichi Fukamachi
=head1 COPYRIGHT
-Copyright (C) 2002,2003,2004 Ken'ichi Fukamachi
+Copyright (C) 2002,2003,2004,2005 Ken'ichi Fukamachi
All rights reserved. This program is free software; you can
redistribute it and/or modify it under the same terms as Perl itself.
diff --git a/fml/lib/FML/Process/ConfViewer.pm b/fml/lib/FML/Process/ConfViewer.pm
index 0e383382..ccdcf6c0 100644
--- a/fml/lib/FML/Process/ConfViewer.pm
+++ b/fml/lib/FML/Process/ConfViewer.pm
@@ -1,9 +1,9 @@
#-*- perl -*-
#
-# Copyright (C) 2000,2001,2002,2003,2004 Ken'ichi Fukamachi
+# Copyright (C) 2000,2001,2002,2003,2004,2005 Ken'ichi Fukamachi
# All rights reserved.
#
-# $FML: ConfViewer.pm,v 1.30 2004/04/23 04:10:36 fukachan Exp $
+# $FML: ConfViewer.pm,v 1.31 2004/07/11 15:43:39 fukachan Exp $
#
package FML::Process::ConfViewer;
@@ -48,7 +48,7 @@ show help unless @ARGV.
=cut
-# Descriptions: constructor
+# Descriptions: constructor.
# Arguments: OBJ($self) HASH_REF($args)
# Side Effects: none
# Return Value: FML::Process::ConfViewer object
@@ -88,10 +88,10 @@ sub prepare
}
-# Descriptions: check @ARGV, call help() if needed
+# Descriptions: check @ARGV, call help() if needed.
# Arguments: OBJ($curproc) HASH_REF($args)
# Side Effects: exit ASAP.
-# longjmp() to help() if appropriate
+# longjmp() to help() if needed.
# Return Value: none
sub verify_request
{
@@ -234,7 +234,7 @@ Ken'ichi Fukamachi
=head1 COPYRIGHT
-Copyright (C) 2000,2001,2002,2003,2004 Ken'ichi Fukamachi
+Copyright (C) 2000,2001,2002,2003,2004,2005 Ken'ichi Fukamachi
All rights reserved. This program is free software; you can
redistribute it and/or modify it under the same terms as Perl itself.
diff --git a/fml/lib/FML/Process/Emulate.pm b/fml/lib/FML/Process/Emulate.pm
index e5f5b65c..25432abf 100644
--- a/fml/lib/FML/Process/Emulate.pm
+++ b/fml/lib/FML/Process/Emulate.pm
@@ -1,9 +1,9 @@
#-*- perl -*-
#
-# Copyright (C) 2004 Ken'ichi Fukamachi
+# Copyright (C) 2004,2005 Ken'ichi Fukamachi
# All rights reserved.
#
-# $FML: Emulate.pm,v 1.4 2004/12/09 04:53:41 fukachan Exp $
+# $FML: Emulate.pm,v 1.5 2004/12/19 11:04:43 fukachan Exp $
#
package FML::Process::Emulate;
@@ -190,6 +190,7 @@ sub _fml4_emulate_error_process
# |/usr/local/fml/libexec/mead.pl \
# -E /usr/local/fml -S /var/spool/ml -D /var/spool/ml/elena
+ # XXX-TODO: disabled for test ?
$curproc->log("start as error mail analyzer mode");
exit(0);
@@ -225,6 +226,7 @@ sub _fml4_emulate_digest_process
# /usr/local/fml/msend.pl /var/spool/ml/elena
$curproc->log("start as article digest mode");
+ # XXX-TODO: disabled for test ?
exit(0);
eval q{
@@ -292,7 +294,7 @@ sub generate_config_cf_from_config_ph
# OK, DO NOTHING.
}
else {
- ;
+ # ? abnormal ???
}
}
@@ -307,7 +309,6 @@ sub _fml4_merge
my $src_dir = $params->{ src_dir } || undef;
my $system = $params->{ target_system } || undef;
- # XXX-TODO: configurable.
use FML::Merge;
my $merge = new FML::Merge $curproc, $params;
$merge->set_target_system($system);
@@ -345,7 +346,7 @@ Ken'ichi Fukamachi
=head1 COPYRIGHT
-Copyright (C) 2004 Ken'ichi Fukamachi
+Copyright (C) 2004,2005 Ken'ichi Fukamachi
All rights reserved. This program is free software; you can
reEmulate it and/or modify it under the same terms as Perl itself.
diff --git a/fml/lib/FML/Process/Error.pm b/fml/lib/FML/Process/Error.pm
index c1c63553..81887830 100644
--- a/fml/lib/FML/Process/Error.pm
+++ b/fml/lib/FML/Process/Error.pm
@@ -3,7 +3,7 @@
# Copyright (C) 2002,2003,2004,2005 Ken'ichi Fukamachi
# All rights reserved.
#
-# $FML: Error.pm,v 1.48 2005/01/01 08:36:29 fukachan Exp $
+# $FML: Error.pm,v 1.49 2005/01/23 00:54:38 fukachan Exp $
#
package FML::Process::Error;
@@ -96,12 +96,12 @@ sub prepare
=head2 verify_request($args)
-dummy.
+set up maintainer.
=cut
-# Descriptions: dummy.
+# Descriptions: set up maintainer.
# Arguments: OBJ($curproc) HASH_REF($args)
# Side Effects: none
# Return Value: 1 or 0
diff --git a/fml/lib/FML/Process/QueueManager.pm b/fml/lib/FML/Process/QueueManager.pm
index 635defa8..b866e36d 100644
--- a/fml/lib/FML/Process/QueueManager.pm
+++ b/fml/lib/FML/Process/QueueManager.pm
@@ -4,7 +4,7 @@
# All rights reserved. This program is free software; you can
# redistribute it and/or modify it under the same terms as Perl itself.
#
-# $FML: QueueManager.pm,v 1.33 2005/01/19 13:49:09 fukachan Exp $
+# $FML: QueueManager.pm,v 1.34 2005/01/23 00:54:39 fukachan Exp $
#
package FML::Process::QueueManager;
@@ -96,6 +96,7 @@ sub send
$ra = [ $id ];
}
else {
+ # XXX-TODO: customizable
$queue->set_policy("fair-queue");
$ra = $queue->list();
unless (@$ra) {
@@ -180,7 +181,7 @@ sub _send
use FML::Mailer;
my $obj = new FML::Mailer $curproc;
- # XXX-TODO: ? no lock for recipient maps here ???
+ # XXX lock for recipient maps is NOT needed since already a copy.
# XXX queue is already locked and need no lock for recipient maps here.
my $r = $obj->send({
sender => $info->{ sender },
@@ -224,6 +225,7 @@ sub cleanup
my $queue = new Mail::Delivery::Queue { directory => $queue_dir };
$queue->set_log_function($fp);
+ # XXX-TODO: customizable. $mail_queue_max_lifetime = 5d ?
my $list = $queue->list_all() || [];
my $limit = 5 * 24 * 3600; # 5 days.
my $now = time;