refactor: drop what no longer carries its weight

- getDirectMessageSpyPlayers had no callers left; handing out a copy of the spy
  map is the shape notifySpies was introduced to replace.
- pluginScope was widened to public for "commands that must not block the tick
  thread", but commands take the delivery queue and only LunaticChat reads it.
- getPlayerChannels returned a Result that cannot fail, so three callers carried
  unreachable error paths and channel.status.error could never be shown.
- The cross-server managers were gated on velocityIntegration.enabled as well as
  on a manager that is non-null only when it is enabled, letting the two
  conditions disagree.
- LenientBoolean's non-YamlInput fallback was observationally identical to the
  cast failing, since both land in ConfigManager's catch-all.
- sendCrossServerMessage caught its own failures underneath the delivery queue,
  which already reports them without stopping the sender's later messages. The
  second boundary is what forced a CancellationException clause here.
- handleOutgoingCrossServerMessage still recorded the reply target after the
  commands took that over, so remote targets were recorded twice - re-inserting
  entries clearPlayer had swept, which is the bug the local path was fixed for.
- The reason delivery is queued was written out in both command constructors and
  twice more in KDoc; it now lives where the queueing happens.

Spy notification also defers its notice lookup and member set until a spy is
actually online, which is not the normal case.

Co-Authored-By: Claude <noreply@anthropic.com>

0 files changed, 0 insertions, 0 deletions