summaryrefslogtreecommitdiff
path: root/fml/lib
diff options
context:
space:
mode:
authorfukachan <fukachan>2004-01-02 14:44:46 +0000
committerfukachan <fukachan>2004-01-02 14:44:46 +0000
commit68d3e930af805bd027148d180be3fa9cb88d5489 (patch)
treeb6bdbaf6000ea37934b607a8817b144fd8b25888 /fml/lib
parent073b66e090c58758b6b16b44e4240e349beaec55 (diff)
downloadfml8-68d3e930af805bd027148d180be3fa9cb88d5489.tar.gz
fml8-68d3e930af805bd027148d180be3fa9cb88d5489.tar.bz2
fml8-68d3e930af805bd027148d180be3fa9cb88d5489.zip
update comments.
sort.
Diffstat (limited to 'fml/lib')
-rw-r--r--fml/lib/FML/Command/Admin/subscribe.pm23
1 files changed, 16 insertions, 7 deletions
diff --git a/fml/lib/FML/Command/Admin/subscribe.pm b/fml/lib/FML/Command/Admin/subscribe.pm
index 47496e00..88a1e0e8 100644
--- a/fml/lib/FML/Command/Admin/subscribe.pm
+++ b/fml/lib/FML/Command/Admin/subscribe.pm
@@ -1,10 +1,10 @@
#-*- perl -*-
#
-# Copyright (C) 2001,2002,2003 Ken'ichi Fukamachi
+# Copyright (C) 2001,2002,2003,2004 Ken'ichi Fukamachi
# All rights reserved. This program is free software; you can
# redistribute it and/or modify it under the same terms as Perl itself.
#
-# $FML: subscribe.pm,v 1.26 2003/11/23 03:54:46 fukachan Exp $
+# $FML: subscribe.pm,v 1.27 2004/01/01 23:52:13 fukachan Exp $
#
package FML::Command::Admin::subscribe;
@@ -68,11 +68,19 @@ sub lock_channel { return 'command_serialize';}
sub process
{
my ($self, $curproc, $command_args) = @_;
- my $config = $curproc->config();
+ my $config = $curproc->config();
+ my $options = $command_args->{ options };
+ my $address = $command_args->{ command_data } || $options->[ 0 ];
+
+ # XXX We should always add/rewrite only $primary_*_map maps via
+ # XXX command mail, CUI and GUI.
+ # XXX Rewriting of maps not $primary_*_map is
+ # XXX 1) may be not writable.
+ # XXX 2) ambigous and dangerous
+ # XXX since the map is under controlled by other module.
+ # XXX for example, one of member_maps is under admin_member_maps.
my $member_map = $config->{ primary_member_map };
my $recipient_map = $config->{ primary_recipient_map };
- my $options = $command_args->{ options };
- my $address = $command_args->{ command_data } || $options->[ 0 ];
# fundamental check
croak("address is not defined") unless defined $address;
@@ -80,6 +88,7 @@ sub process
croak("\$member_map is not specified") unless $member_map;
croak("\$recipient_map is not specified") unless $recipient_map;
+ # XXX-TODO: validate $address syntax.
# FML::User::Control specific parameters
my $uc_args = {
address => $address,
@@ -98,7 +107,7 @@ sub process
}
-# Descriptions: show cgi menu for subscribe
+# Descriptions: show cgi menu for subscribe command.
# Arguments: OBJ($self) OBJ($curproc) HASH_REF($command_args)
# Side Effects: update $member_map $recipient_map
# Return Value: none
@@ -128,7 +137,7 @@ Ken'ichi Fukamachi
=head1 COPYRIGHT
-Copyright (C) 2001,2002,2003 Ken'ichi Fukamachi
+Copyright (C) 2001,2002,2003,2004 Ken'ichi Fukamachi
All rights reserved. This program is free software; you can
redistribute it and/or modify it under the same terms as Perl itself.