diff options
| author | Sho Sakuma <me@m1sk9.dev> | 2026-08-03 15:19:08 +0900 |
|---|---|---|
| committer | Sho Sakuma <me@m1sk9.dev> | 2026-08-05 01:16:03 +0900 |
| commit | d45db164428bb4b350c879bf3f43ceb1cc581955 (patch) | |
| tree | 2c9ccedf53e5a24597631c97e20201e1caeaff29 /engine/build.gradle.kts | |
| parent | 576c057bb98dab27c2b97931fc5635603fe1bf57 (diff) | |
| download | LunaticChat-d45db164428bb4b350c879bf3f43ceb1cc581955.tar.gz LunaticChat-d45db164428bb4b350c879bf3f43ceb1cc581955.tar.bz2 LunaticChat-d45db164428bb4b350c879bf3f43ceb1cc581955.zip | |
refactor: keep rendering out of CommandResult
CommandResult carried Adventure Components, which was engine's last
Minecraft dependency and the reason CLAUDE.md's "engine has no Minecraft
platform dependencies" was not quite true. It also meant a command could
not report a result without having already decided how it looks: every
site had to pick formatError versus format before it could return.
Results now carry text, and LunaticCommandBase.handleResult is the single
place that styles it - error red for Failure, normal for
SuccessWithMessage. The fail()/ok() helpers from #260 already funnelled
every call site through two functions, so this is a change to those two
plus the one command that composes its own success text.
engine's dependency list is down to kotlinx-serialization, and nothing
under engine/src references net.kyori, org.bukkit, com.velocitypowered or
io.papermc.
Not done: the review also proposed collapsing the per-command
`when (error)` blocks into one exception-to-key table. Those blocks pick
wording, not just a key - "only owners can delete this channel" reads
differently in the ban command than the delete command - so a shared table
would hand every caller the same sentence and need per-command overrides
on top. Left alone deliberately.
Co-Authored-By: Claude <noreply@anthropic.com>
Diffstat (limited to 'engine/build.gradle.kts')
| -rw-r--r-- | engine/build.gradle.kts | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/engine/build.gradle.kts b/engine/build.gradle.kts index 2d36116..5782890 100644 --- a/engine/build.gradle.kts +++ b/engine/build.gradle.kts @@ -7,10 +7,4 @@ dependencies { // Exposed to platform modules via api(): the plugin messaging protocol is built on it, so // both platforms need it on their compile and runtime classpath. api("org.jetbrains.kotlinx:kotlinx-serialization-json:1.11.0") - - // Adventure API (provided by platform implementations) - // Matches what every supported platform ships: Paper 26.2 and Velocity 4.x both bundle 5.2.0. - compileOnly("net.kyori:adventure-api:5.2.0") - - testImplementation("net.kyori:adventure-api:5.2.0") } |
